Attention is currently required from: Wonkyu Kim. Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/55073
to look at the new patch set (#3).
Change subject: cpu/x86/lapic: Add Kconfig choice LAPIC_ACCESS_MODE ......................................................................
cpu/x86/lapic: Add Kconfig choice LAPIC_ACCESS_MODE
Allows compile-time optimisation on platforms that do not wish to enable runtime checking of X2APIC.
Legacy lapic_cpu_init() is incompatible so there is dependency on PARALLEL_MP. Also stop_this_cpu() is incompatible, so there is dependency on !AP_IN_SIPI_WAIT.
Since the code actually lacks enablement of X2APIC (apparently assuming the blob has done it) and the other small flaws pointed out in earlier reviews, X2APIC_RUNTIME is not selected per default on any platform yet.
Change-Id: I8269f9639ee3e89a2c2b4178d266ba2dac46db3f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/x86/Kconfig M src/cpu/x86/lapic/lapic.c M src/include/cpu/x86/lapic.h 3 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/55073/3