Change in coreboot[master]: mb/google/hatch/helios: Update GPIO and device tree

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Tim Wawrzynczak (Code Review)

23 Jul 2019 23 Jul '19

7:40 p.m.

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

mb/google/hatch/helios: Update GPIO and device tree

Based on updated schematics, change polarity of USI_INT, and add the rest of the control GPIOs to the touchscreen ACPI node.

BUG=b:137133194 BRANCH=none TEST=Compiles, don't have next board rev to test with

Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/helios/overridetree.cb 2 files changed, 12 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/34528/1

diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 8a0c948..04028cb 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -195,8 +195,8 @@ PAD_NC(GPP_D14, NONE), /* D15 : TOUCHSCREEN_RST_L */ PAD_CFG_GPO(GPP_D15, 0, DEEP), - /* D16 : USI_INT */ - PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, NONE), + /* D16 : USI_INT_L */ + PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, INVERT), /* D17 : PCH_HP_SDW_CLK */ PAD_NC(GPP_D17, NONE), /* D18 : PCH_HP_SDW_DAT */ diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 41c15c8..aebdab7 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -83,13 +83,19 @@ chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.irq" = + "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "10" - register "generic.reset_off_delay_ms" = "1" + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + register "generic.reset_delay_ms" = "120" + register "generic.reset_off_delay_ms" = "3" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "generic.enable_delay_ms" = "10" register "generic.has_power_resource" = "1" + register "generic.stop_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H14)" register "hid_desc_reg_offset" = "0x01" device i2c 5d on end end

Attachments:

attachment.htm (text/html — 5.4 KB)

Show replies by date

Paul Fagerburg (Code Review)

23 Jul 23 Jul

7:56 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 23 Jul 2019 19:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8:30 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... PS1, Line 198: USI_INT_L This change seems to be done in baseboard/gpio.c. Is the hardware change done for all variants?

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... PS1, Line 91: 120 That's a long delay. Just a note: This affects resume time from S0ix since the delay sits in a critical path. It would be good to raise a separate bug to later on test if we really need such a long delay.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 23 Jul 2019 20:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

8:59 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... PS1, Line 198: USI_INT_L

...

This change seems to be done in baseboard/gpio.c. […]

Kohaku and Helios have it called out as active low, I missed Kindred. I'll update individual GPIO files.

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... PS1, Line 91: 120

...

That's a long delay. […]

Other devices using the same part have this delay set. I don't see any details about these numbers in the datasheets, I just wanted to use the conservative number until the specified number is found.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 23 Jul 2019 20:59:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Philip Chen (Code Review)

9:06 p.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 1:

Is this change compatible with the Helios rev0?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 23 Jul 2019 21:06:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

9:09 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 1:

...

Patch Set 1:

Is this change compatible with the Helios rev0?

IIRC, that rev didn't come with the touchscreen IC, so it shouldn't hurt anything.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 23 Jul 2019 21:09:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:17 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... PS1, Line 91: 120

...

Other devices using the same part have this delay set. […]

Oh okay. Makes sense. Yeah I just intended to highlight that this will eventually come up as one of the blocks resulting in longer resume time.

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... PS1, Line 98: GPP_H14 This seems to be NC in gpio.c. Is it really used/required?

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 23 Jul 2019 21:17:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

9:35 p.m.

Hello Paul Fagerburg, Philip Chen, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34528

to look at the new patch set (#2).

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

mb/google/hatch/helios: Update GPIO and device tree

Based on updated schematics, change polarity of USI_INT, and add the rest of the control GPIOs to the touchscreen ACPI node.

BUG=b:137133194 BRANCH=none TEST=Compiles, don't have next board rev to test with

Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/helios/gpio.c M src/mainboard/google/hatch/variants/helios/overridetree.cb 2 files changed, 15 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/34528/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tim Wawrzynczak (Code Review)

9:36 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... PS1, Line 91: 120

...

Oh okay. Makes sense. […]

Ack

https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/... PS1, Line 98: GPP_H14

...

This seems to be NC in gpio.c. […]

In Helios' gpio.c, this is TOUCHSCREEN_STOP_L. Taking a closer look, it doesn't look like Goodix's kernel driver even uses that GPIO. Left it in for now, with a note to take another look at the reset/enable/stop times & signals.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 23 Jul 2019 21:36:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

24 Jul 24 Jul

12:02 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Jul 2019 00:02:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

11:02 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 2: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Jul 2019 11:02:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:29 p.m.

Hello Paul Fagerburg, Philip Chen, Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34528

to look at the new patch set (#3).

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

mb/google/hatch/helios: Update GPIO and device tree

Based on updated schematics, change polarity of USI_INT, and add the rest of the control GPIOs to the touchscreen ACPI node.

BUG=b:137133194, b:138240502 BRANCH=none TEST=Compiles, don't have next board rev to test with

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/34528/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Fagerburg (Code Review)

5:41 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Jul 2019 17:41:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:57 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34528/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/gpio.c:

https://review.coreboot.org/c/coreboot/+/34528/3/src/mainboard/google/hatch/... PS3, Line 95: 1 nit: Since this is now de-asserted in power resource, it can be left asserted here. However, since this does not seem to be going to a real stop gpio pin on the touchscreen controller, it probably wouldn't matter much.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Jul 2019 17:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6:52 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34528/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/helios/gpio.c:

https://review.coreboot.org/c/coreboot/+/34528/3/src/mainboard/google/hatch/... PS3, Line 95: 1

...

nit: Since this is now de-asserted in power resource, it can be left asserted here. […]

Actually, taking a closer look at the schematics, it needs to be asserted here, because the GPIO gates off the reset line, which will cause the power sequencing in _ON to fail. The stop_gpio needs to be removed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Jul 2019 18:52:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6:54 p.m.

Hello Paul Fagerburg, Philip Chen, Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34528

to look at the new patch set (#4).

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

mb/google/hatch/helios: Update GPIO and device tree

Based on updated schematics, change polarity of USI_INT, and add the reset and enable GPIOs to the touchscreen ACPI node. The stop GPIO can't be used with the current implementation of _ON, as the way it's wired will cause power sequencing to fail.

BUG=b:137133194, b:138240502 BRANCH=none TEST=Compiles, don't have next board rev to test with

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/34528/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Paul Fagerburg (Code Review)

7:05 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 24 Jul 2019 19:05:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

26 Jul 26 Jul

12:58 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34528 )

Change subject: mb/google/hatch/helios: Update GPIO and device tree ......................................................................

mb/google/hatch/helios: Update GPIO and device tree

BUG=b:137133194, b:138240502 BRANCH=none TEST=Compiles, don't have next board rev to test with

Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34528 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M src/mainboard/google/hatch/variants/helios/gpio.c M src/mainboard/google/hatch/variants/helios/overridetree.cb 2 files changed, 10 insertions(+), 3 deletions(-)

Approvals: build bot (Jenkins): Verified Paul Fagerburg: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/helios/gpio.c b/src/mainboard/google/hatch/variants/helios/gpio.c index 12801de..ecb13f3 100644 --- a/src/mainboard/google/hatch/variants/helios/gpio.c +++ b/src/mainboard/google/hatch/variants/helios/gpio.c @@ -51,6 +51,8 @@ PAD_NC(GPP_D8, NONE), /* D10 : ISH_SPI_CLK ==> EN_PP3300_PP1800_FP */ PAD_CFG_GPO(GPP_D10, 0, DEEP), + /* D16 : USI_INT_L */ + PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, INVERT), /* D21 : SPI1_IO2 ==> NC */ PAD_NC(GPP_D21, NONE), /* F0 : GPP_F0 ==> NC */ @@ -90,7 +92,7 @@ /* H13 : M2_SKT2_CFG1 ==> SPKR_RST_L */ PAD_CFG_GPO(GPP_H13, 1, DEEP), /* H14 : M2_SKT2_CFG2 ==> TOUCHSCREEN_STOP_L */ - PAD_CFG_GPO(GPP_H14, 0, PLTRST), + PAD_CFG_GPO(GPP_H14, 1, PLTRST), /* H19 : TIMESYNC[0] ==> MEM_STRAP_0 */ PAD_CFG_GPI(GPP_H19, NONE, PLTRST), /* H22 : MEM_STRAP_1 */ diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 41c15c8..cedf046 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -83,12 +83,17 @@ chip drivers/i2c/hid register "generic.hid" = ""GDIX0000"" register "generic.desc" = ""Goodix Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" + register "generic.irq" = + "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" register "generic.probed" = "1" register "generic.reset_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" + "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" register "generic.reset_delay_ms" = "10" register "generic.reset_off_delay_ms" = "1" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "generic.enable_delay_ms" = "10" + register "generic.enable_off_delay_ms" = "1" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" device i2c 5d on end

-- To view, visit https://review.coreboot.org/c/coreboot/+/34528 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2 Gerrit-Change-Number: 34528 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1759

days inactive

1762

days old

coreboot-gerrit@coreboot.org

17 comments

6 participants

tags (0)

participants (6)

Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Paul Menzel (Code Review)
Philip Chen (Code Review)
Tim Wawrzynczak (Code Review)