Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )
Change subject: mb/google/hatch/helios: Update GPIO and device tree
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/...
PS1, Line 91: 120
Other devices using the same part have this delay set. […]
Oh okay. Makes sense. Yeah I just intended to highlight that this will eventually come up as one of the blocks resulting in longer resume time.
https://review.coreboot.org/c/coreboot/+/34528/1/src/mainboard/google/hatch/...
PS1, Line 98: GPP_H14
This seems to be NC in gpio.c. Is it really used/required?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34528
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2
Gerrit-Change-Number: 34528
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 23 Jul 2019 21:17:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment