Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34528 )
Change subject: mb/google/hatch/helios: Update GPIO and device tree
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34528/3/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/helios/gpio.c:
https://review.coreboot.org/c/coreboot/+/34528/3/src/mainboard/google/hatch/...
PS3, Line 95: 1
nit: Since this is now de-asserted in power resource, it can be left asserted here. […]
Actually, taking a closer look at the schematics, it needs to be asserted here, because the GPIO gates off the reset line, which will cause the power sequencing in _ON to fail. The stop_gpio needs to be removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34528
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1dfb8e649418e4c5e9b897fb4bc11393adc21ea2
Gerrit-Change-Number: 34528
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 24 Jul 2019 18:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment