Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52763 )
Change subject: soc/amd/common: Add placeholder GPIO macro, PAD_UNCHANGED ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52763/comment/09e1428a_8baece54 PS1, Line 9: GPIOs can only be updated in gpio_configure_pads_with_override() if they : are present in the base table. If they are not there, the override : does not work. This allows them to be in the base table so that they can : be overridden without changing the existing configuration.
Hrmm, can we die() if we encounter such a problem? It's a configuration error that needs to be fixed […]
This is nothing to do about "behavior in Intel ChromeOS platforms". The primary reason is that mainboard must configure all pads in ramstage. Now, with the base/override logic, the base table is expected to contain the configuration for all pads so that the override table can update those in case they differ from what the base table provides.
The solution depends on what the end goal is. If it is to ensure we avoid these misconfigurations, then a `die()` call makes sense.