Attention is currently required from: Nico Huber, Arthur Heymans, Patrick Rudolph. Hello Nico Huber, Arthur Heymans, Patrick Rudolph,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55044
to review the following change.
Change subject: [TESTME] nb/intel/sandybridge: Redefine `DMIBAR32_UPDATE` ......................................................................
[TESTME] nb/intel/sandybridge: Redefine `DMIBAR32_UPDATE`
Redefine the `DMIBAR32_UPDATE` macro to do a read-modify-write sequence.
Change-Id: I15f8b16b9b9eea7f8c30937dbc50a5eddf5a4bb4 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/sandybridge/early_dmi.c 1 file changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/55044/1
diff --git a/src/northbridge/intel/sandybridge/early_dmi.c b/src/northbridge/intel/sandybridge/early_dmi.c index cfd0d0b..30e8109 100644 --- a/src/northbridge/intel/sandybridge/early_dmi.c +++ b/src/northbridge/intel/sandybridge/early_dmi.c @@ -6,11 +6,7 @@ #include <northbridge/intel/sandybridge/sandybridge.h> #include <southbridge/intel/bd82x6x/pch.h>
-#define DMIBAR32_UPDATE(x, val, clear, set) \ - do { \ - dmibar_read32(x); \ - dmibar_write32(x, ((val) & ~(clear)) | (set)); \ - } while (0) +#define DMIBAR32_UPDATE(x, val, clear, set) dmibar_clrsetbits32(x, clear, set)
static void dmi_recipe(void) {