Attention is currently required from: Konrad Adamczyk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Tim Van Patten, Fred Reitberger, Felix Held.
Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74779 )
Change subject: soc/amd/common/block/graphics: Add missing cbfs_unmap()
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74779/comment/46499acc_28df9e12
PS1, Line 9: cbfs_map() can allocate memory, so cbfs_unmap() should be
: called before leaving the function.
This needs to be updated, since `cbfs_unmap()` isn't being called here anymore.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74779
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6fbbfd36f0974551befef4d08423a8148e151e7
Gerrit-Change-Number: 74779
Gerrit-PatchSet: 2
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Konrad Adamczyk
konrada@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Konrad Adamczyk
konrada@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 27 Apr 2023 12:03:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment