Attention is currently required from: wouter.eckhardt@prodrive-technologies.com, Guido Beyer @ Prodrive Technologies, Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons, Stef van Os.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54058 )
Change subject: mb/prodrive/hermes: Disable ACPI S3 and S4 with SPS
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Does S3 resume work on the X11 boards with ME instead of SPS? Something you could check is whether the RAM can ever stay powered on in S3, where only the +5VSB rail remains powered on.
Damn, thanks for reminding me. IIRC that was the problem, why S3 doesn't work on these server boards... may be different on the desktop / workstation boards, though.
Ideally, coreboot would detect the ME/SPS firmware SKU and report supported sleep states accordingly. However, this involves more work.
Thought about that, too, but we can't detect if S3 is supported by the hardware so we still need a Kconfig for S3/S5 hardware support.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54058
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d0fa8530e198e86415f92da6719d2fb0d2401ec
Gerrit-Change-Number: 54058
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies
guido.beyer@prodrive-technologies.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-Attention: wouter.eckhardt@prodrive-technologies.com
Gerrit-Attention: Guido Beyer @ Prodrive Technologies
guido.beyer@prodrive-technologies.com
Gerrit-Attention: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Stef van Os
stef.van.os@prodrive-technologies.com
Gerrit-Comment-Date: Tue, 11 May 2021 16:42:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment