EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41506 )
Change subject: mb/google/deltaur: Add tcss.asl ......................................................................
mb/google/deltaur: Add tcss.asl
Add tcss.asl to support TCSS power management. For the detail please refer cb:39785.
BUG=none TEST=Check /sys/bus/pci/devices/bus:device:func/power suspend and active time can increase.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I432f3d6643de13b08c07e47f799c0ecdfe047de6 --- M src/mainboard/google/deltaur/dsdt.asl 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/41506/1
diff --git a/src/mainboard/google/deltaur/dsdt.asl b/src/mainboard/google/deltaur/dsdt.asl index 03067ae..702820c 100644 --- a/src/mainboard/google/deltaur/dsdt.asl +++ b/src/mainboard/google/deltaur/dsdt.asl @@ -28,6 +28,7 @@ { #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/tigerlake/acpi/southbridge.asl> + #include <soc/intel/tigerlake/acpi/tcss.asl> } }
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41506 )
Change subject: mb/google/deltaur: Add tcss.asl ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41506/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41506/1//COMMIT_MSG@13 PS1, Line 13: bus:device:func which one?
Hello build bot (Jenkins), Tim Wawrzynczak, Bora Guvendik, Selma Bensaid,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41506
to look at the new patch set (#2).
Change subject: mb/google/deltaur: Add tcss.asl ......................................................................
mb/google/deltaur: Add tcss.asl
Add tcss.asl to support TCSS power management. For the detail please refer cb:39785.
BUG=none TEST=Check TBT PCIe root ports: 00:07.0/00:07.1/00:07.2/00:07.3 /sys/bus/pci/devices/bus:device:func/power suspend and active time can increase.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I432f3d6643de13b08c07e47f799c0ecdfe047de6 --- M src/mainboard/google/deltaur/dsdt.asl 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/41506/2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41506 )
Change subject: mb/google/deltaur: Add tcss.asl ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41506/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41506/1//COMMIT_MSG@13 PS1, Line 13: bus:device:func
which one?
I added it from https://review.coreboot.org/c/coreboot/+/39785 :) We don't enable DMA.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41506 )
Change subject: mb/google/deltaur: Add tcss.asl ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41506 )
Change subject: mb/google/deltaur: Add tcss.asl ......................................................................
mb/google/deltaur: Add tcss.asl
Add tcss.asl to support TCSS power management. For the detail please refer cb:39785.
BUG=none TEST=Check TBT PCIe root ports: 00:07.0/00:07.1/00:07.2/00:07.3 /sys/bus/pci/devices/bus:device:func/power suspend and active time can increase.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I432f3d6643de13b08c07e47f799c0ecdfe047de6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41506 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/deltaur/dsdt.asl 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/deltaur/dsdt.asl b/src/mainboard/google/deltaur/dsdt.asl index fe86e15..fac58bd 100644 --- a/src/mainboard/google/deltaur/dsdt.asl +++ b/src/mainboard/google/deltaur/dsdt.asl @@ -25,6 +25,7 @@ { #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/tigerlake/acpi/southbridge.asl> + #include <soc/intel/tigerlake/acpi/tcss.asl> } }
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41506 )
Change subject: mb/google/deltaur: Add tcss.asl ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3642 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3641 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3640 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3639
Please note: This test is under development and might not be accurate at all!