Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81029?usp=email )
Change subject: acpi: Guard CBMEM driver against Chrome devices ......................................................................
acpi: Guard CBMEM driver against Chrome devices
Commit ce10b6f82185baa2a777d946ca6c9ba72d3d6ef8 unhid the BOOT0000 device from Windows. It requires a driver that's available from Coolstars EC bundle.
Guard this against the ChromeEC, so that non-Chromebooks don't get an error device in Device Manager.
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I6645c1be7d602a2775f703f5cf56e4c9d6f3bb76 Reviewed-on: https://review.coreboot.org/c/coreboot/+/81029 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/acpi/acpi.c 1 file changed, 4 insertions(+), 1 deletion(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index 06aa038c..ffd9b79 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -304,7 +304,10 @@ acpigen_write_device("CTBL"); acpigen_write_coreboot_hid(COREBOOT_ACPI_ID_CBTABLE); acpigen_write_name_integer("_UID", 0); - acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); + if (CONFIG(EC_GOOGLE_CHROMEEC)) + acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON); + else + acpigen_write_STA(ACPI_STATUS_DEVICE_HIDDEN_ON); acpigen_write_name("_CRS"); acpigen_write_resourcetemplate_header(); acpigen_resource_consumer_mmio(base, base + size - 1,