Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29398 )
Change subject: src/soc/intel/braswell/southcluster.c: Correct serial IRQ support
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/29398/5/src/soc/intel/braswell/Kconfig
File src/soc/intel/braswell/Kconfig:
https://review.coreboot.org/#/c/29398/5/src/soc/intel/braswell/Kconfig@137
PS5, Line 137:
: config ENABLE_SERIRQ
: bool "Enable Serial IRQ"
: default n
: help
: Enable Serial IRQ
:
: config SERIRQ_CONTINUOUS_MODE
: bool "Serial IRQ continuous mode"
: default n
: depends on ENABLE_SERIRQ
: help
: Enable Serial IRQ continuous mode
Do Chromebooks want to have the SERIRQ disabled as it was in the 'old' code base? Most coreboot boar […]
In 'old' code base it was disabled, so to avoid causing problems when SERIRQ becomes enabled this feature is default disabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29398
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7844cad69dc0563fa6109d779d0afb7c2edd7245
Gerrit-Change-Number: 29398
Gerrit-PatchSet: 5
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 28 Feb 2019 10:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment