Attention is currently required from: Felix Singer, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67272 )
Change subject: util/docker/coreboot-jenkins-node: Install cmocka
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
The coreboot-sdk coreboot build will continue to use 3rdparty/cmocka, I guess. […]
It seems a little odd, all the other flashrom dependencies are also in coreboot-sdk.
But tests are optional and coreboot builds anyway, so this is not a blocker.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b
Gerrit-Change-Number: 67272
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Thu, 01 Sep 2022 15:28:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Gerrit-MessageType: comment