Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55946 )
Change subject: mb/google/brya: Update controller field for tbt_dma entries
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55946/comment/7eb02ca1_1e5536f3
PS1, Line 145: .group = ACPI_PLD_GROUP(1, 1),
: .controller = 0,
Good call, that makes for a better interface. […]
Ack
Yes Tim, we were supposed to give DMA controller number but that was just to get correct port number.
Thank you Tim and Furquan for review. Interface is better now 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20c088ee81610155067abad086eba8d72f73ad60
Gerrit-Change-Number: 55946
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Abhijeet Rao
abhijeet.rao@intel.corp-partner.google.com
Gerrit-CC: Deepti Deshatty
deepti.deshatty@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 01 Jul 2021 09:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment