Attention is currently required from: Star Labs, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52800 )
Change subject: soc/intel: Allow enable/disable ME via CMOS ......................................................................
Patch Set 20:
(3 comments)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/52800/comment/5e220f24_d57bce9a PS20, Line 847: print_me_fw_version I don't think you want to enable/disable a device in a function that should print the FW version.
https://review.coreboot.org/c/coreboot/+/52800/comment/0a0b9273_8e2b1139 PS20, Line 871: #if CONFIG(ME_STATE_BY_CMOS) Use C code instead of CPP.
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/52800/comment/c42fd8eb_d89ee093 PS20, Line 181: /* Methods for disabling/enabling the ME */ : int enable_me(void); : int disable_me(void); Any reason to have those exposed in the header?