Attention is currently required from: Jeremy Soller, Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80756?usp=email )
Change subject: mb/system76/adl,rpl: Add FSP default timeout for PCIe 3.0 RPs ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80756/comment/4b3c79f0_0d75999b : PS1, Line 7: Add timeouts for PCIe 3.0 RPs :
Maybe: […]
Leaving as-is and explaining it's the FSP default value in the body.
https://review.coreboot.org/c/coreboot/+/80756/comment/ad1e4a65_c8ac9af0 : PS1, Line 14: Tested on lemp12 with Samsung 980 PRO and 990 PRO drives.
What drive firmware versions?
Done
https://review.coreboot.org/c/coreboot/+/80756/comment/8cdc788a_08f426f6 : PS1, Line 15:
Is there a default time-out value? Why 50 ms and not another value?
Changed to use FSP default of 56ms.
File src/mainboard/system76/adl/variants/darp8/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/80756/comment/8ef4a3c2_f64b5c0a : PS1, Line 155: .pcie_rp_detect_timeout_ms = 50,
Is there a default timeout?
Done