Attention is currently required from: Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78609?usp=email )
Change subject: cpu/intel/model_206ax: Program Ivy Bridge defaults for MSR_PKGC_IRTL
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/78609/comment/0f6c37de_d6ac7141 :
PS5, Line 192: cpuid_eax(1) >= 0x30600
use a variable "const bool is_ivybridge = cpuid_eax(1) >= 0x30600;" ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78609?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib307e3b191ba68e016cc348f82e2dccf1dc9ae16
Gerrit-Change-Number: 78609
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Sat, 18 Nov 2023 13:36:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment