Sunwei Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46871 )
Change subject: Enable MT8183_DRAM_EMCP for kakadu ......................................................................
Enable MT8183_DRAM_EMCP for kakadu
BUG=b:171841122
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I44668ce630758e49fbf2c6028f56c01f83ff08f8 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46871/1
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 23a4169..cff94da 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -36,7 +36,7 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER - select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE + select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE || BOARD_GOOGLE_KAKADU
config MAINBOARD_DIR string
Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46871 )
Change subject: Enable MT8183_DRAM_EMCP for kakadu ......................................................................
Patch Set 1: Code-Review+1
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46871 )
Change subject: Enable MT8183_DRAM_EMCP for kakadu ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46871/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46871/1//COMMIT_MSG@7 PS1, Line 7: Enable MT8183_DRAM_EMCP for kakadu mb/google/kukui: enable EMCP for kakadu
The Kakadu project will be using EMCP board design.
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Tao Xia, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46871
to look at the new patch set (#2).
Change subject: mb/google/kukui:Enable MT8183_DRAM_EMCP for kakadu ......................................................................
mb/google/kukui:Enable MT8183_DRAM_EMCP for kakadu
Enable MT8183_DRAM_EMCP for kakadu
BUG=b:171841122 TEST=Boots on chromebook Kakadu successfully.
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I44668ce630758e49fbf2c6028f56c01f83ff08f8 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46871/2
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Tao Xia, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46871
to look at the new patch set (#3).
Change subject: mb/google/kukui:Enable MT8183_DRAM_EMCP for kakadu ......................................................................
mb/google/kukui:Enable MT8183_DRAM_EMCP for kakadu
The Kakadu project will be using EMCP board design.
BUG=b:171841122 TEST=Boots on chromebook Kakadu successfully.
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I44668ce630758e49fbf2c6028f56c01f83ff08f8 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46871/3
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46871 )
Change subject: mb/google/kukui:Enable MT8183_DRAM_EMCP for kakadu ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46871/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46871/1//COMMIT_MSG@7 PS1, Line 7: Enable MT8183_DRAM_EMCP for kakadu
mb/google/kukui: enable EMCP for kakadu […]
Done
https://review.coreboot.org/c/coreboot/+/46871/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46871/3//COMMIT_MSG@9 PS3, Line 9: EMCP eMCP
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46871 )
Change subject: mb/google/kukui:Enable MT8183_DRAM_EMCP for kakadu ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46871/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46871/3//COMMIT_MSG@7 PS3, Line 7: : One space after ":"
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Tao Xia, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46871
to look at the new patch set (#4).
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for kakadu ......................................................................
mb/google/kukui: Enable MT8183_DRAM_EMCP for kakadu
The Kakadu project will be using EMCP board design.
BUG=b:171841122 TEST=Boots on chromebook Kakadu successfully.
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I44668ce630758e49fbf2c6028f56c01f83ff08f8 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46871/4
Hello Hung-Te Lin, Jianbo Zhang, build bot (Jenkins), Patrick Georgi, Tao Xia, Xuxin Xiong, Yu-Ping Wu, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46871
to look at the new patch set (#5).
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for kakadu ......................................................................
mb/google/kukui: Enable MT8183_DRAM_EMCP for kakadu
The Kakadu project will be using eMCP board design.
BUG=b:171841122 TEST=Boots on chromebook Kakadu successfully.
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I44668ce630758e49fbf2c6028f56c01f83ff08f8 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/46871/5
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46871 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for kakadu ......................................................................
Patch Set 5: Code-Review+2
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46871 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for kakadu ......................................................................
Patch Set 5: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/46871/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46871/3//COMMIT_MSG@7 PS3, Line 7: :
One space after ":"
Done
https://review.coreboot.org/c/coreboot/+/46871/3//COMMIT_MSG@9 PS3, Line 9: EMCP
eMCP
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46871 )
Change subject: mb/google/kukui: Enable MT8183_DRAM_EMCP for kakadu ......................................................................
mb/google/kukui: Enable MT8183_DRAM_EMCP for kakadu
The Kakadu project will be using eMCP board design.
BUG=b:171841122 TEST=Boots on chromebook Kakadu successfully.
Signed-off-by: Sunway lisunwei@huaqin.corp-partner.google.com Change-Id: I44668ce630758e49fbf2c6028f56c01f83ff08f8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46871 Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Yu-Ping Wu yupingso@google.com Reviewed-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Yu-Ping Wu: Looks good to me, approved Tao Xia: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 23a4169..cff94da 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -36,7 +36,7 @@ select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER - select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE + select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE || BOARD_GOOGLE_KAKADU
config MAINBOARD_DIR string
-
Hung-Te Lin (Code Review) -
Patrick Georgi (Code Review)
-
Sunwei Li (Code Review)
-
Tao Xia (Code Review)
-
Yu-Ping Wu (Code Review)