Attention is currently required from: Jérémy Compostella, Paul Menzel, Subrata Banik, Wonkyu Kim.
Ashish Kumar Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80088?usp=email )
Change subject: cpu/x86: Add 1GiB pages for memory access up to 512GiB ......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80088/comment/35051819_f1efb9df : PS2, Line 7: src/
Please remove.
Done
File src/cpu/x86/64bit/pt1G.S:
https://review.coreboot.org/c/coreboot/+/80088/comment/4768dcdd_280b80a0 : PS2, Line 3: /*
Remove the leading space?
Done
File src/cpu/x86/64bit/pt1G.S:
https://review.coreboot.org/c/coreboot/+/80088/comment/fd796e35_af4489d0 : PS3, Line 4: Page table attributes: WB, User+Supervisor, Present, Writeable, Accessed, Dirty : */
missing leading space on line 4 and 5.
Done
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/80088/comment/bce5a6c3_480abba2 : PS2, Line 157: Select this option to access above 4GiB pagetable using 1GiB pages.
Could you elaborate?
Done
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/80088/comment/80f4458c_8c879144 : PS3, Line 157: Select this option to access above 4GiB pagetable using 1GiB pages, upto : 512GiB, instead of the default access below 4GiB using 2MiB pages.
What about: […]
Done