Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56617 )
Change subject: soc/intel/alderlake: Clear RTC_BATTERY_DEAD ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/56617/comment/d8d8a9cb_d01dd6c2 PS1, Line 188: soc_get_rtc_failed
This series looks okay to me. I am wondering if there is scope for us to simplify things somewhat. […]
Handling RTC failures in bootblock sounds like a good idea, especially considering that some CMOS options are read in bootblock and/or romstage.
Looks like this is also what Intel suggests doing. Document 549921 (SKL/KBL PCH BS) section 5.11 (Platform Controller Hub (PCH) Boot Checklist) lists checking the RTC Battery failure bit before programming I/O base addresses (ABASE, TCOBASE) and before disabling the watchdog timer reset.
-
Angel Pons (Code Review)