Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67355 )
Change subject: soc/mediatek/mt8188: Enable mfgpll properly and fix SPMI muxes
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67355/comment/2a632e02_578c14a3
PS4, Line 7: enable
Enable
Done
File src/soc/mediatek/mt8188/pll.c:
https://review.coreboot.org/c/coreboot/+/67355/comment/bb0c0ce1_ac6958eb
PS4, Line 524: /* disable mfg_ck_en[20], enable mfg_opp_ck_en[2] */
: clrbits32(&mtk_apmixed->mfgpll_con0, 0x1 << 20);
: clrsetbits32(&mtk_apmixed->mfgpll_con0, 0x1 << 2, 0x1 << 2);
clrsetbits32(&mtk_apmixed->mfgpll_con0, BIT(20), BIT(2));
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67355
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I971109a5f72e3307899daaf5a5f26022124b559b
Gerrit-Change-Number: 67355
Gerrit-PatchSet: 5
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 07:36:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment