Attention is currently required from: Tarun Tuli, Jérémy Compostella, Ravishankar Sarawadi, Paul Menzel, Kapil Porwal.
Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68308 )
Change subject: soc/intel/meteorlake: Increase pcie snoop/no-snoop latency
......................................................................
Patch Set 9:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68308/comment/519c38cc_d04e2ad9
PS6, Line 7: Update
Increase
Done
https://review.coreboot.org/c/coreboot/+/68308/comment/c8cdf07c_8443854c
PS6, Line 10: This fixes an issue where pcie
: was not power gating and blocked S0ix entry.
I prefer to start commit message with a problem description.
Done
https://review.coreboot.org/c/coreboot/+/68308/comment/31a87f93_c02bcec9
PS6, Line 13: BUG=none
Why?
because there is no partner bug associated with it.
File src/soc/intel/meteorlake/pcie.c:
https://review.coreboot.org/c/coreboot/+/68308/comment/f44eb999_9e04488b
PS6, Line 9:
Why do you put it here, and not `src/include/device/pciexp. […]
changed now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dfb9edbac95d28d50653777466ea172be64f612
Gerrit-Change-Number: 68308
Gerrit-PatchSet: 9
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 03 May 2023 22:38:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment