Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44114 )
Change subject: Documentation: Fix sphinx configuration ......................................................................
Documentation: Fix sphinx configuration
Without the brackets, the string seems to be added as a list of characters, and since there's no extension called 's', sphinx bails out.
Change-Id: If0fc9c1a74f334b6154df3cb26836509de913567 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/conf.py 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/44114/1
diff --git a/Documentation/conf.py b/Documentation/conf.py index f82fa0e..3180fd9 100644 --- a/Documentation/conf.py +++ b/Documentation/conf.py @@ -48,7 +48,7 @@ except ImportError: print("Error: Please install sphinxcontrib.ditaa for ASCII art conversion\n") else: - extensions += 'sphinxcontrib.ditaa' + extensions += ['sphinxcontrib.ditaa']
# The language for content autogenerated by Sphinx. Refer to documentation # for a list of supported languages.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44114 )
Change subject: Documentation: Fix sphinx configuration ......................................................................
Patch Set 1: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44114 )
Change subject: Documentation: Fix sphinx configuration ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44114 )
Change subject: Documentation: Fix sphinx configuration ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44114 )
Change subject: Documentation: Fix sphinx configuration ......................................................................
Documentation: Fix sphinx configuration
Without the brackets, the string seems to be added as a list of characters, and since there's no extension called 's', sphinx bails out.
Change-Id: If0fc9c1a74f334b6154df3cb26836509de913567 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44114 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/conf.py 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Documentation/conf.py b/Documentation/conf.py index f82fa0e..3180fd9 100644 --- a/Documentation/conf.py +++ b/Documentation/conf.py @@ -48,7 +48,7 @@ except ImportError: print("Error: Please install sphinxcontrib.ditaa for ASCII art conversion\n") else: - extensions += 'sphinxcontrib.ditaa' + extensions += ['sphinxcontrib.ditaa']
# The language for content autogenerated by Sphinx. Refer to documentation # for a list of supported languages.