Attention is currently required from: Kornel Dulęba, Nick Vaccaro, Paweł Anikiel.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78297?usp=email )
Change subject: drivers/wwan/fm: Wake up modem on PEWAKE# signal change
......................................................................
Patch Set 3:
(2 comments)
File src/drivers/wwan/fm/acpi_fm350gl.c:
https://review.coreboot.org/c/coreboot/+/78297/comment/d510db5a_565391ca :
PS3, Line 6: #if CONFIG(GENERIC_GPIO_LIB)
: #include <gpio.h>
: #endif
order please.
why not adding header file unconditionally ?
https://review.coreboot.org/c/coreboot/+/78297/comment/f3d9a045_9e1f1964 :
PS3, Line 287: #if CONFIG(GENERIC_GPIO_LIB)
why preprocessing guard ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78297?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32257689da85ea71f9de781093b3ede0cfe70a0e
Gerrit-Change-Number: 78297
Gerrit-PatchSet: 3
Gerrit-Owner: Paweł Anikiel
panikiel@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jakub Czapiga
czapiga@google.com
Gerrit-CC: Kornel Dulęba
korneld@google.com
Gerrit-Attention: Paweł Anikiel
panikiel@google.com
Gerrit-Attention: Kornel Dulęba
korneld@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 17 Oct 2023 04:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment