Attention is currently required from: Sean Rhodes, Martin Roth, Stefan Reinauer.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61550 )
Change subject: payloads/tianocore: Remove used build option
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
since we do offer the ability to build from upstream edk2 master (or any commit really), we probably want to correct rather than remove the param, or at the least make it a Kconfig option for the payload when the 'upstream' option is selected
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61550
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic52e0afa7744f4a902274c41aed59ca23fd9f5fc
Gerrit-Change-Number: 61550
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Wed, 02 Feb 2022 20:04:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment