Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/27433 )
Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/27433/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/include/variant/gpio.h:
https://review.coreboot.org/#/c/27433/1/src/mainboard/google/poppy/variants/... PS1, Line 44:
Is GPP_D8 not connected now? You will have to configure it accordingly in gpio.c: https://review. […]
I left GPP_D8 configured in gpio.c on purpose, to allow camera development on preEVT2 devices as well as EVT2. GPP_D8 is a NC in EVT2, and GPP_B4 is a NC in preEVT2, so it should be safe. I filed a reminder bug for cleanup once we're ready to obsolete preEVT2 (https://b.corp.google.com/issues/110066750)
-
Nick Vaccaro (Code Review)