Change in coreboot[master]: libpayload: Enable UART driver for sc7280

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ravi kumar (Code Review)

12 Nov 2020 12 Nov '20

6:27 p.m.

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Signed-off-by: Roja Rani Yarubandi rojay@codeaurora.org --- M payloads/libpayload/Kconfig M payloads/libpayload/configs/config.herobrine M payloads/libpayload/drivers/Makefile.inc D payloads/libpayload/drivers/serial/sc7280.c 4 files changed, 1 insertion(+), 17 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/1

diff --git a/payloads/libpayload/Kconfig b/payloads/libpayload/Kconfig index 52be71d..f5b81a9 100644 --- a/payloads/libpayload/Kconfig +++ b/payloads/libpayload/Kconfig @@ -264,11 +264,6 @@ depends on SERIAL_CONSOLE default n

-config SC7280_SERIAL_CONSOLE - bool "SC7280 SOC compatible serial port driver" - depends on SERIAL_CONSOLE - default n - config QUALCOMM_QUPV3_SERIAL_CONSOLE bool "Qualcomm QUPV3 serial port driver" depends on SERIAL_CONSOLE diff --git a/payloads/libpayload/configs/config.herobrine b/payloads/libpayload/configs/config.herobrine index a9d576a..18ca19d 100644 --- a/payloads/libpayload/configs/config.herobrine +++ b/payloads/libpayload/configs/config.herobrine @@ -2,4 +2,4 @@ CONFIG_LP_ARCH_ARM64=y CONFIG_LP_TIMER_ARM64_ARCH=y CONFIG_LP_SERIAL_CONSOLE=y -CONFIG_LP_SC7280_SERIAL_CONSOLE=y +CONFIG_LP_QUALCOMM_QUPV3_SERIAL_CONSOLE=y diff --git a/payloads/libpayload/drivers/Makefile.inc b/payloads/libpayload/drivers/Makefile.inc index 6c54c49..c4f7bf6 100644 --- a/payloads/libpayload/drivers/Makefile.inc +++ b/payloads/libpayload/drivers/Makefile.inc @@ -42,8 +42,6 @@ libc-$(CONFIG_LP_PC_MOUSE) += i8042/mouse.c libc-$(CONFIG_LP_PC_I8042) += i8042/i8042.c

-libc-$(CONFIG_LP_SC7280_SERIAL_CONSOLE) += serial/sc7280.c serial/serial.c - libc-$(CONFIG_LP_CBMEM_CONSOLE) += cbmem_console.c

libc-$(CONFIG_LP_MOUSE_CURSOR) += mouse_cursor.c diff --git a/payloads/libpayload/drivers/serial/sc7280.c b/payloads/libpayload/drivers/serial/sc7280.c deleted file mode 100644 index 0d7f5cf..0000000 --- a/payloads/libpayload/drivers/serial/sc7280.c +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include <libpayload.h> - -/* For simplicity sake let's rely on coreboot initalizing the UART. */ -void serial_console_init(void) -{ - -}

Attachments:

attachment.htm (text/html — 5.3 KB)

Show replies by date

Shelley Chen (Code Review)

4 Feb 4 Feb

11:46 p.m.

Attention is currently required from: Ravi kumar. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3: Oh interesting. Looks like you got rid of the sc7280 serial driver addition from https://review.coreboot.org/c/coreboot/+/45206 here...

Ravi kumar (Code Review)

8 Mar 8 Mar

10:08 a.m.

Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#7).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/7

Ravi kumar (Code Review)

18 Mar 18 Mar

5:15 a.m.

Attention is currently required from: mturney mturney. Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#10).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/10

Ravi kumar (Code Review)

2:08 p.m.

Attention is currently required from: Ravi kumar. Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#12).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Signed-off-by: Roja Rani Yarubandi rojay@codeaurora.org --- M payloads/libpayload/configs/config.herobrine 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/12

Ravi kumar (Code Review)

2:25 p.m.

Attention is currently required from: Ravi kumar. Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#13).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/13

mturney mturney (Code Review)

4:11 p.m.

Attention is currently required from: mturney mturney. mturney mturney has uploaded a new patch set (#14) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/14

Ravi kumar (Code Review)

23 Mar 23 Mar

7:28 p.m.

Attention is currently required from: Ravi kumar, mturney mturney. Hello build bot (Jenkins), Patrick Georgi, Martin Roth,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#20).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/20

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 20 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Shelley Chen shchen@google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

31 Mar 31 Mar

5:42 a.m.

Attention is currently required from: Ravi kumar, Julius Werner. Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#28).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/28

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 28 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-CC: Shelley Chen shchen@google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: newpatchset

Shelley Chen (Code Review)

25 May 25 May

9:05 p.m.

Attention is currently required from: Ravi kumar, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

Patch Set 42: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 42 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Tue, 25 May 2021 21:05:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ravi kumar (Code Review)

16 Jun 16 Jun

7:49 p.m.

New subject: Change in coreboot[master]: WIP libpayload: Enable UART driver for sc7280 WIP

Attention is currently required from: Ravi kumar, Julius Werner. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#49).

Change subject: WIP libpayload: Enable UART driver for sc7280 WIP ......................................................................

WIP libpayload: Enable UART driver for sc7280 WIP

Add Qualcomm's QUPV3 serial driver for herobrine board

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/49

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 49 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

29 Jun 29 Jun

2:27 p.m.

Attention is currently required from: Ravi kumar, Julius Werner. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#52).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

BUG=b:182963902 TEST=Validated on qualcomm sc7180 and sc7280 development board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/52

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 52 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

5 Jul 5 Jul

6:18 p.m.

Attention is currently required from: Ravi kumar, Julius Werner. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#55).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

BUG=b:182963902 TEST=Validated on qualcomm sc7180 and sc7280 development board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/55

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 55 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: newpatchset

Shelley Chen (Code Review)

12 Jul 12 Jul

9:57 p.m.

Attention is currently required from: Ravi kumar, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

Patch Set 56: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 56 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Mon, 12 Jul 2021 21:57:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

9:57 p.m.

Attention is currently required from: Ravi kumar, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

Patch Set 56: Code-Review+1

(1 comment)

Patchset:

PS56: Change looks good. I'll +2 it once Jenkins verifies the change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 56 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Mon, 12 Jul 2021 21:57:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Ravi kumar (Code Review)

14 Jul 14 Jul

2 p.m.

Attention is currently required from: Ravi kumar, Julius Werner. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#58).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

BUG=b:182963902 TEST=Validated on qualcomm sc7180 and sc7280 development board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/58

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 58 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: newpatchset

Shelley Chen (Code Review)

25 Aug 25 Aug

12:25 a.m.

Attention is currently required from: Ravi kumar, Sudheer Amrabadi, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

Patch Set 66: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 66 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Sudheer Amrabadi samrabad@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-Comment-Date: Wed, 25 Aug 2021 00:25:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

12:26 a.m.

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

Patch Set 66:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47527/comment/de4c78a0_62f2a862 PS66, Line 12: sc7180 probably just the sc7280 board.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 66 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-Comment-Date: Wed, 25 Aug 2021 00:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Ravi kumar (Code Review)

26 Aug 26 Aug

4:14 p.m.

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#67).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/67

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 67 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

8 Sep 8 Sep

1:29 p.m.

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#70).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/70

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 70 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

13 Sep 13 Sep

12:18 p.m.

Attention is currently required from: Ravi kumar, Julius Werner, mturney mturney. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#71).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/71

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 71 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi Kumar Bokka (Code Review)

15 Sep 15 Sep

10:10 a.m.

Attention is currently required from: Shelley Chen, Ravi kumar, Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

Patch Set 71:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/47527/comment/4a61a153_a699eb63 PS66, Line 12: sc7180

...

probably just the sc7280 board.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 71 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Wed, 15 Sep 2021 10:10:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen shchen@google.com Gerrit-MessageType: comment

Ravi kumar (Code Review)

21 Sep 21 Sep

7:32 p.m.

Attention is currently required from: Shelley Chen, Ravi kumar, Julius Werner. Hello Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Julius Werner,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47527

to look at the new patch set (#74).

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/47527/74

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 74 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Shelley Chen shchen@google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-MessageType: newpatchset

Shelley Chen (Code Review)

5 Oct 5 Oct

11:39 p.m.

Attention is currently required from: Ravi kumar, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

Patch Set 78: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 78 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: Julius Werner jwerner@chromium.org Gerrit-Comment-Date: Tue, 05 Oct 2021 23:39:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Shelley Chen (Code Review)

6 Oct 6 Oct

11:57 p.m.

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47527 )

Change subject: libpayload: Enable UART driver for sc7280 ......................................................................

libpayload: Enable UART driver for sc7280

Add Qualcomm's QUPV3 serial driver for herobrine board

BUG=b:182963902 TEST=Validated on qualcomm sc7280 development board.

Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Signed-off-by: Roja Rani Yarubandi rojay@codeaurora.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/47527 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Shelley Chen shchen@google.com --- M payloads/libpayload/configs/config.herobrine 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Shelley Chen: Looks good to me, approved

diff --git a/payloads/libpayload/configs/config.herobrine b/payloads/libpayload/configs/config.herobrine index e87f71a..18ca19d 100644 --- a/payloads/libpayload/configs/config.herobrine +++ b/payloads/libpayload/configs/config.herobrine @@ -2,3 +2,4 @@ CONFIG_LP_ARCH_ARM64=y CONFIG_LP_TIMER_ARM64_ARCH=y CONFIG_LP_SERIAL_CONSOLE=y +CONFIG_LP_QUALCOMM_QUPV3_SERIAL_CONSOLE=y

78 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47527 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a745afd7bbabdd29f1f369612c990526e5a2335 Gerrit-Change-Number: 47527 Gerrit-PatchSet: 80 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: Julius Werner jwerner@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com Gerrit-MessageType: merged

1150

days inactive

1478

days old

coreboot-gerrit@coreboot.org

24 comments

4 participants

tags (0)

participants (4)

mturney mturney (Code Review)
Ravi kumar (Code Review)
Ravi Kumar Bokka (Code Review)
Shelley Chen (Code Review)