Hannah Williams has posted comments on this change. ( https://review.coreboot.org/19603 )
Change subject: soc/intel/apollolake: Bring in delta for GLK SOC
......................................................................
Patch Set 59:
(2 comments)
https://review.coreboot.org/#/c/19603/59/src/soc/intel/apollolake/acpi/lpss....
File src/soc/intel/apollolake/acpi/lpss.asl:
Line 20: Method(LPD3, 0, Serialized) {
What is this for? Comments are required.
putting LPSS in D3
https://review.coreboot.org/#/c/19603/59/src/soc/intel/apollolake/bootblock/...
File src/soc/intel/apollolake/bootblock/bootblock.c:
Line 38: #if !IS_ENABLED(CONFIG_SOC_INTEL_GLK)
why?
It is default enabled as Native Function on GLK
--
To view, visit
https://review.coreboot.org/19603
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e76726bb77f0277ab5776ae9d3d42b7eb389fe3
Gerrit-PatchSet: 59
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Brenton Dong
brenton.m.dong@intel.com
Gerrit-Reviewer: Cole Nelson
colex.nelson@intel.com
Gerrit-Reviewer: Han Lim Ng
nhlhanlim93@gmail.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes