Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40306 )
Change subject: drivers/ipmi: Add IPMI read FRU chassis info area ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c... PS8, Line 96: /* Read data string from data_ptr and store it to string, return the please follow code comment style from https://www.coreboot.org/Coding_Style
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c... PS8, Line 123: void there are a bunch of errors this function detect. Lets return error code on failure
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c... PS8, Line 131: if (!offset) : return; not: may be move this upper?
-
Andrey Petrov (Code Review)