Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46570 )
Change subject: mb/google/asurada: fix EC_IN_RW polarity ......................................................................
mb/google/asurada: fix EC_IN_RW polarity
EC_IN_RW should be low active.
Please merge this to CB:46386.
BUG=None TEST=None
Signed-off-by: Hung-Te Lin hungte@chromium.org Change-Id: If23898ebc6a1a0bcec910873a07b7470f9aa3dd5 --- M src/mainboard/google/asurada/chromeos.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/46570/1
diff --git a/src/mainboard/google/asurada/chromeos.c b/src/mainboard/google/asurada/chromeos.c index 18a350b..a57392b 100644 --- a/src/mainboard/google/asurada/chromeos.c +++ b/src/mainboard/google/asurada/chromeos.c @@ -20,7 +20,7 @@ void fill_lb_gpios(struct lb_gpios *gpios) { struct lb_gpio chromeos_gpios[] = { - {GPIO_EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"}, + {GPIO_EC_IN_RW.id, ACTIVE_LOW, -1, "EC in RW"}, {GPIO_EC_AP_INT.id, ACTIVE_LOW, -1, "EC interrupt"}, {GPIO_H1_AP_INT.id, ACTIVE_HIGH, -1, "TPM interrupt"}, {GPIO_SD_CD.id, ACTIVE_HIGH, -1, "SD card detect"},
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46570 )
Change subject: mb/google/asurada: fix EC_IN_RW polarity ......................................................................
Patch Set 1:
Hi Yidi, please merge this to CB:46386.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46570 )
Change subject: mb/google/asurada: fix EC_IN_RW polarity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46570/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/chromeos.c:
https://review.coreboot.org/c/coreboot/+/46570/1/src/mainboard/google/asurad... PS1, Line 23: ACTIVE_LOW Verified that gpio454 is 1 after normal boot.
BTW, the base number is 284, as the "gpiochip284" directory name suggests.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46570 )
Change subject: mb/google/asurada: fix EC_IN_RW polarity ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46570/1/src/mainboard/google/asurad... File src/mainboard/google/asurada/chromeos.c:
https://review.coreboot.org/c/coreboot/+/46570/1/src/mainboard/google/asurad... PS1, Line 23: ACTIVE_LOW
Verified that gpio454 is 1 after normal boot. […]
got it, thanks!
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46570 )
Change subject: mb/google/asurada: fix EC_IN_RW polarity ......................................................................
Patch Set 1:
Patch Set 1:
Hi Yidi, please merge this to CB:46386.
done
Hung-Te Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46570 )
Change subject: mb/google/asurada: fix EC_IN_RW polarity ......................................................................
Abandoned
already merged
-
Hung-Te Lin (Code Review) -
Yidi Lin (Code Review)
-
Yu-Ping Wu (Code Review)