[S] Change in coreboot[master]: nb/intel/gm45: Make polling loops more explicit - coreboot-gerrit

2 Nov 2022


      Attention is currently required from: Felix Singer, Nico Huber, Arthur Heymans, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69077 )
Change subject: nb/intel/gm45: Make polling loops more explicit
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
Another commonly used way to write it is to put the ';' on the next line.
One concern with this approach is that the semicolon seems to be spurious if one doesn't take the context into account. If memory serves right, Jenkins also warns about it.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbf3cf072f8b817b2fdeece4ef89bae0822bb6e6
Gerrit-Change-Number: 69077
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 02 Nov 2022 10:54:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment