Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/19372 )
Change subject: soc/intel/common/block: Add Intel common SMBus code ......................................................................
Patch Set 8:
(6 comments)
https://review.coreboot.org/#/c/19372/8/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/smbus.h:
Line 20: #define SMBUS_IO_BASE 0xefa0
This is needed to be exposed because why? Because of the weird split in imp
Ok.Moved SMBUS_IO_BASE ,smbus_read8/smbus_write8 functions to smbuslib.h ,local to common block.
Line 26: void smbus_common_init(void);
Please provide a comment indicating what the function does, etc.
Done
https://review.coreboot.org/#/c/19372/8/src/soc/intel/common/block/smbus/smb... File src/soc/intel/common/block/smbus/smbus.c:
Line 100: 0xa123, /* SunRisePoint H */
Just put these in include/device/pci_ids.h like I noted on the previous CL.
Done
https://review.coreboot.org/#/c/19372/8/src/soc/intel/common/block/smbus/smb... File src/soc/intel/common/block/smbus/smbuslib.c:
Line 54: inb(0x80);
Is there a reason we aren't using the normal timer.h APIs?
Revised implementation to use timer APIs from timer.h in PS#9.Please review.
PS8, Line 167: {
no need for curlies
Done
PS8, Line 181: u32
It seems you are relying on src/include/device/smbus.h as the common declar
There was difference in declaration(parameter count) between early_smbus.h and device/smbus.h,hence did not pursue to unify it,Also it is being defined at many places in code,would have evolved into bigger change.