Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Angel Pons.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62471 )
Change subject: soc/mediatek/mt8186: Add GPIO driving functions
......................................................................
Patch Set 9:
(3 comments)
File src/soc/mediatek/mt8186/gpio.c:
https://review.coreboot.org/c/coreboot/+/62471/comment/82292ba3_df74c050
PS9, Line 203: { 0, 0, 0, }
Let's define
#define GPIO_NOT_IMPLEMENTED ((struct gpio_drv_info){ 0, 0, 0 })
https://review.coreboot.org/c/coreboot/+/62471/comment/989ff6dd_29d0b091
PS9, Line 483: (
No need for parentheses.
https://review.coreboot.org/c/coreboot/+/62471/comment/08370ea0_2fd3fbef
PS9, Line 488: (
No need for parentheses.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62471
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d987f28be98b515fa5c542222bda08bea1d5118
Gerrit-Change-Number: 62471
Gerrit-PatchSet: 9
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 07 Mar 2022 01:59:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment