Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37672 )
Change subject: mb/facebook/monolith: Revert fmd update ......................................................................
mb/facebook/monolith: Revert fmd update
Revert the fmd changes to implement the % tag.
Wait until cbfstool supports it.
BUG=N/A TEST=build
Change-Id: I2dc8b8f56ee0890e01be3bed939ed922feb15e89 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/vboot-rw.fmd 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/37672/1
diff --git a/src/mainboard/facebook/monolith/vboot-rw.fmd b/src/mainboard/facebook/monolith/vboot-rw.fmd index fad0f97..fd7811b 100644 --- a/src/mainboard/facebook/monolith/vboot-rw.fmd +++ b/src/mainboard/facebook/monolith/vboot-rw.fmd @@ -12,14 +12,14 @@ } RW_SECTION_A@0x20000 0x860000 { VBLOCK_A@0x0 0x10000 - RW_FWID_A@0x10000% 0x40 - FW_MAIN_A(CBFS)@0x10040% 0x84FFC0 + RW_FWID_A@0x10000 0x40 + FW_MAIN_A(CBFS)@0x10040 0x84FFC0 } WP_RO@0x880000 0x080000 { RO_SECTION@0x0000 0x80000 { - FMAP@0x0% 0x800 - RO_FRID@0x800% 0x40 - RO_FRID_PAD@0x840% 0x7c0 + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 GBB@0x1000 0x4000 COREBOOT(CBFS)@0x5000 0x07B000 }
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37672
to look at the new patch set (#2).
Change subject: mb/facebook/monolith: Remove % tag from fmd file ......................................................................
mb/facebook/monolith: Remove % tag from fmd file
cbfstool doesn't support % tag yet while this was in the fmd.
Revert the fmd changes that use the % tag.
BUG=N/A TEST=build
Change-Id: I2dc8b8f56ee0890e01be3bed939ed922feb15e89 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/vboot-rw.fmd 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/37672/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37672 )
Change subject: mb/facebook/monolith: Remove % tag from fmd file ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37672 )
Change subject: mb/facebook/monolith: Remove % tag from fmd file ......................................................................
mb/facebook/monolith: Remove % tag from fmd file
cbfstool doesn't support % tag yet while this was in the fmd.
Revert the fmd changes that use the % tag.
BUG=N/A TEST=build
Change-Id: I2dc8b8f56ee0890e01be3bed939ed922feb15e89 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37672 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/monolith/vboot-rw.fmd 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/facebook/monolith/vboot-rw.fmd b/src/mainboard/facebook/monolith/vboot-rw.fmd index fad0f97..fd7811b 100644 --- a/src/mainboard/facebook/monolith/vboot-rw.fmd +++ b/src/mainboard/facebook/monolith/vboot-rw.fmd @@ -12,14 +12,14 @@ } RW_SECTION_A@0x20000 0x860000 { VBLOCK_A@0x0 0x10000 - RW_FWID_A@0x10000% 0x40 - FW_MAIN_A(CBFS)@0x10040% 0x84FFC0 + RW_FWID_A@0x10000 0x40 + FW_MAIN_A(CBFS)@0x10040 0x84FFC0 } WP_RO@0x880000 0x080000 { RO_SECTION@0x0000 0x80000 { - FMAP@0x0% 0x800 - RO_FRID@0x800% 0x40 - RO_FRID_PAD@0x840% 0x7c0 + FMAP@0x0 0x800 + RO_FRID@0x800 0x40 + RO_FRID_PAD@0x840 0x7c0 GBB@0x1000 0x4000 COREBOOT(CBFS)@0x5000 0x07B000 }
-
Frans Hendriks (Code Review) -
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)