Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53902 )
Change subject: sc7280: Add PCIe RC driver in Coreboot ......................................................................
Patch Set 2:
(26 comments)
File src/soc/qualcomm/sc7280/include/soc/addressmap.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/e875c0e6_a1d043d9 PS2, Line 68: #define PCIE1_MEM_SIZE 0x1fd00000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/f3670553_8c3e3a92 PS2, Line 69: #define PCIE_MEM_END 0x404fffff please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/ab256a3c_b24efe4a PS2, Line 72: #define PCIE_1_QMP_PHY 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/74f09455_abfa3908 PS2, Line 76: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
File src/soc/qualcomm/sc7280/include/soc/pcie.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/0285f8a6_ef20bc47 PS2, Line 18: #define DEV_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/0d511555_dfef4211 PS2, Line 19: #define CLASS_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/4f220ecd_eb2783a3 PS2, Line 20: #define HEADER_SZ 8 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/a37c91a1_109b3790 PS2, Line 21: #define VEND_ID_SZ 16 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/15622355_b47e60de PS2, Line 25: #define PCIE_CLASS 0x0a please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/70c3f0b8_d7ebf153 PS2, Line 26: #define PCI_MAX_DEV_FN 0x100 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/0fc19be1_8ef1adf9 PS2, Line 41: #define PCIE1_3x2_NUM_LANES 2 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/c3d163d6_04fde7c1 PS2, Line 57: #define PERST_DELAY_US 1000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/e505b1a0_3111e3cf PS2, Line 58: #define PCIE_MAX_BARS 6 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/1f05f43e_77e492d2 PS2, Line 154: #define PCIE1_QMP_PHY_PCS_COM 0x01C0EA00 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/a9cc2992_9bad9917 PS2, Line 155: #define PCE1_QPHY_SERDES 0x01C0E000 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/23bf460f_6616b056 PS2, Line 156: #define PCE1_QPHY_TX0 0x01C0E200 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/a5d42af5_2a24b423 PS2, Line 157: #define PCE1_QPHY_RX0 0x01C0E400 please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/9aad10b3_da63ee73 PS2, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/0406ea69_6f3d86bc PS2, Line 169: #define PCIE_DEV_FUNC (dev,func) PCI_SLOT(devfn) | PCI_FUNC(devfn) Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/67bc2b70_eb8589b4 PS2, Line 188: #define PCIE_DEV(_bus, _dev, _fn) (0x80000000 | \ Macros with complex values should be enclosed in parentheses
File src/soc/qualcomm/sc7280/pcie_host.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/3318ffee_b682c3f5 PS2, Line 303: pci_ep_cfg_info.config_base = (void*)PCIE1_GEN3x2_CONF; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/961fe9ae_a0b63a7c PS2, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/2edf56e1_3419f2b0 PS2, Line 459: printk(BIOS_INFO,"pcie ep PERST asserted \n"); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/d26f5122_f7df754b PS2, Line 468: printk(BIOS_NOTICE,"pcie ep PERST desserted\n"); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/73d0dfc9_8acd9d2a PS2, Line 773: if (vend_id == 0xffff || vend_id == 0x0000) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119033): https://review.coreboot.org/c/coreboot/+/53902/comment/dd903dad_da228daa PS2, Line 1140: if(!ret) space required before the open parenthesis '('
-
build bot (Jenkins) (Code Review)