Yegor Timoshenko has posted comments on this change. ( https://review.coreboot.org/28953 )
Change subject: treewide: use /usr/bin/env where appropriate ......................................................................
Patch Set 1:
(3 comments)
Thank you for review! :-)
Will change `/usr/bin/env python` to `/usr/bin/env python2` where appropriate.
https://review.coreboot.org/#/c/28953/1/util/amdtools/k8-compare-pci-space.p... File util/amdtools/k8-compare-pci-space.pl:
https://review.coreboot.org/#/c/28953/1/util/amdtools/k8-compare-pci-space.p... PS1, Line 5: use warnings;
Why has this been added?
This has the same effect as `-w` flag. Shebangs can only have one argument, which in this case is program basename. See: https://stackoverflow.com/a/570279
https://review.coreboot.org/#/c/28953/1/util/chromeos/extract_blobs.sh File util/chromeos/extract_blobs.sh:
https://review.coreboot.org/#/c/28953/1/util/chromeos/extract_blobs.sh@17 PS1, Line 17: set -x
What is this for?
This flag makes shell print every command invocation to stderr. It was in shebang.
https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py File util/ipqheader/mbn_tools.py:
https://review.coreboot.org/#/c/28953/1/util/ipqheader/mbn_tools.py@1 PS1, Line 1: #!/usr/bin/env python
This resolves to Python 3 in my system (Arch Linux), but this script seems Python 2 (I get syntax er […]
This probably would have been the case with previous shebang as well though.
I agree this should be `/usr/bin/env python2`.