Thank you for review! :-)

Will change `/usr/bin/env python` to `/usr/bin/env python2` where appropriate.

View Change

3 comments:

• File util/amdtools/k8-compare-pci-space.pl:

  • Patch Set #1, Line 5: use warnings;

    Why has this been added?

    This has the same effect as `-w` flag. Shebangs can only have one argument, which in this case is program basename. See: https://stackoverflow.com/a/570279

• File util/chromeos/extract_blobs.sh:

  • Patch Set #1, Line 17: set -x

    What is this for?

    This flag makes shell print every command invocation to stderr. It was in shebang.

• File util/ipqheader/mbn_tools.py:

  • Patch Set #1, Line 1: #!/usr/bin/env python

    This resolves to Python 3 in my system (Arch Linux), but this script seems Python 2 (I get syntax er […]

    This probably would have been the case with previous shebang as well though.

    I agree this should be `/usr/bin/env python2`.

To view, visit change 28953. To unsubscribe, or for help writing mail filters, visit settings.