[S] Change in coreboot[master]: mb/starlabs/starbook: Let coreboot configure ASPM - coreboot-gerrit

27 Apr 2023


      Attention is currently required from: Sean Rhodes, Paul Menzel, Maximilian Brune.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74520 )
Change subject: mb/starlabs/starbook: Let coreboot configure ASPM
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74520/comment/271c0470_480d6572 
PS1, Line 10: lower power consumption
...
is this 0. […]
AFAIR, the FSP UPDs control only the root port's capabilities and not its effective
configuration or that of the PCIe endpoint.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74520
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib15eaede956f0aa55118d093fdff0fd9487df250
Gerrit-Change-Number: 74520
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Comment-Date: Thu, 27 Apr 2023 16:00:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes sean@starlabs.systems
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-MessageType: comment