Attention is currently required from: Arthur Heymans, Jérémy Compostella, Nico Huber.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81886?usp=email )
Change subject: arch/x86: Prevent .text/.init overlap with older linkers ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81886/comment/733631e9_ede0ded2 : PS2, Line 11: (binutils 2.3x)
Are you sure this is used with the main branch? I was told ChromeOS always uses the newest toolchain (and hence we have to restrict toolchain updates to the releases). binutils was updated to 2.40 a year ago.
we are still using 2.37 version and raised an internal bug https://b.corp.google.com/issues/332445618 to perform an uprev to 2.42 to switch to the new binutil. But as said, the existing EDK2 builds are failing (as Intel FSP/EDK2 code are not supportive of the latest tool chain).
https://review.coreboot.org/c/coreboot/+/81886/comment/326aef17_dd5e4619 : PS2, Line 11: Default is 1024 bytes (1 KiB)
There was a comment on another change (CB:81678) stating that SIZEOF() is returning 0 (with the old binutils). If that's the case, 1KiB might not be enough (possibly depending on alignment).
I have made a test run on all platform using chromium mainline and don't see any issue after picking this CL. but point noted incase we run into any issue in future.
-
Subrata Banik (Code Review)