Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held.
Nikolai Vyssotski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52746 )
Change subject: soc/amd/picasso: Move Type 17 DMI generation to common
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/Kconfig.common:
https://review.coreboot.org/c/coreboot/+/52746/comment/f2f1a16a_ac5cf071
PS2, Line 11: _
Add a _COMMON
Done
File src/soc/amd/common/fsp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/52746/comment/dbaf3d2a_4b758fe2
PS2, Line 7: ramstage-y
How about `ramstage-$(CONFIG_SOC_AMD_FSP_DMI_TABLES)` +=
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52746
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46071556bbbbf6435d9e3724bba19e102bd02535
Gerrit-Change-Number: 52746
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 04 Jun 2021 22:39:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment