Attention is currently required from: David Wu, Eran Mitrani, Eric Lai, Kapil Porwal, Tarun, YH Lin.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78216?usp=email )
Change subject: mb/google/rex/var/karis: Add FAN field in fw_config
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/rex/variants/karis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/78216/comment/618dadd6_7c9d811e :
PS5, Line 244: probe FAN FAN_SETTING_1
Are you sure? this will turn off the all table if no FAN... If for no fan, you need create new one. […]
Yes, if it has "no FAN" config, we will create new one for it.
Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78216?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id69ec67202b5d769cd3a9a68344a6d8913ebd78b
Gerrit-Change-Number: 78216
Gerrit-PatchSet: 5
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 16 Oct 2023 05:34:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment