Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43749 )
Change subject: Doc: mb/facebook/monolith: Fix TianoCore commit hash ......................................................................
Doc: mb/facebook/monolith: Fix TianoCore commit hash
The commit hash is the same as the SeaBIOS one, and is indeed from the SeaBIOS repository.
Change-Id: I820b9b748778050fc694c13b1e2b2fc80885b4f1 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/43749/1
diff --git a/Documentation/mainboard/facebook/monolith.md b/Documentation/mainboard/facebook/monolith.md index cdd3208..b81387e 100644 --- a/Documentation/mainboard/facebook/monolith.md +++ b/Documentation/mainboard/facebook/monolith.md @@ -104,7 +104,7 @@ - SMBus - Initialization with FSP - SeaBIOS payload (commit a5cab58e9a3fb6e168aba919c5669bea406573b4) -- TianoCore payload (commit a5cab58e9a3fb6e168aba919c5669bea406573b4) +- TianoCore payload (commit ?) - LinuxBoot (kernel kernel-4_19_97) (uroot commit 9c9db9dbd6b532f5f91a511a0de885c6562aadd7) - eMMC
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43749 )
Change subject: Doc: mb/facebook/monolith: Fix TianoCore commit hash ......................................................................
Patch Set 1: Code-Review-1
Wim, could you please tell me the used hash. Then I could update the documentation.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43749 )
Change subject: Doc: mb/facebook/monolith: Fix TianoCore commit hash ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43749/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43749/1//COMMIT_MSG@7 PS1, Line 7: Doc: mb/facebook/monolith Doc/mb/facebook/monolith
https://review.coreboot.org/c/coreboot/+/43749/1/Documentation/mainboard/fac... File Documentation/mainboard/facebook/monolith.md:
https://review.coreboot.org/c/coreboot/+/43749/1/Documentation/mainboard/fac... PS1, Line 107: (commit ?) If no one can figure it out, I'd just drop this altogether.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43749 )
Change subject: Doc: mb/facebook/monolith: Fix TianoCore commit hash ......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
Wim, could you please tell me the used hash. Then I could update the documentation.
The Tianocore commit was : 860a8d95c2ee89c9916d6e11230f246afa1cd629
Looks like I made a mistake quickly updating this documentation. Sorry about that.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43749 )
Change subject: Doc: mb/facebook/monolith: Fix TianoCore commit hash ......................................................................
Patch Set 1:
Thanks for noticing this mistake.
Hello build bot (Jenkins), Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43749
to look at the new patch set (#2).
Change subject: Doc/mb/facebook/monolith: Use correct TianoCore commit hash ......................................................................
Doc/mb/facebook/monolith: Use correct TianoCore commit hash
The commit hash is the same as the SeaBIOS one, and is indeed from the SeaBIOS repository.
Change-Id: I820b9b748778050fc694c13b1e2b2fc80885b4f1 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/43749/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43749 )
Change subject: Doc/mb/facebook/monolith: Use correct TianoCore commit hash ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43749 )
Change subject: Doc/mb/facebook/monolith: Use correct TianoCore commit hash ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43749/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43749/1//COMMIT_MSG@7 PS1, Line 7: Doc: mb/facebook/monolith
Doc/mb/facebook/monolith
Done
https://review.coreboot.org/c/coreboot/+/43749/1/Documentation/mainboard/fac... File Documentation/mainboard/facebook/monolith.md:
https://review.coreboot.org/c/coreboot/+/43749/1/Documentation/mainboard/fac... PS1, Line 107: (commit ?)
If no one can figure it out, I'd just drop this altogether.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43749 )
Change subject: Doc/mb/facebook/monolith: Use correct TianoCore commit hash ......................................................................
Doc/mb/facebook/monolith: Use correct TianoCore commit hash
The commit hash is the same as the SeaBIOS one, and is indeed from the SeaBIOS repository.
Change-Id: I820b9b748778050fc694c13b1e2b2fc80885b4f1 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/43749 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/mainboard/facebook/monolith.md 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/facebook/monolith.md b/Documentation/mainboard/facebook/monolith.md index cdd3208..db8c246 100644 --- a/Documentation/mainboard/facebook/monolith.md +++ b/Documentation/mainboard/facebook/monolith.md @@ -104,7 +104,7 @@ - SMBus - Initialization with FSP - SeaBIOS payload (commit a5cab58e9a3fb6e168aba919c5669bea406573b4) -- TianoCore payload (commit a5cab58e9a3fb6e168aba919c5669bea406573b4) +- TianoCore payload (commit 860a8d95c2ee89c9916d6e11230f246afa1cd629) - LinuxBoot (kernel kernel-4_19_97) (uroot commit 9c9db9dbd6b532f5f91a511a0de885c6562aadd7) - eMMC
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wim Vervoorn (Code Review)