Attention is currently required from: Jarried Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86095?usp=email )
Change subject: soc/mediatek/mt8196: Add PI_IMG firmware v1.0 ......................................................................
Patch Set 1:
(4 comments)
File soc/mediatek/mt8196/README.md:
https://review.coreboot.org/c/blobs/+/86095/comment/18ae52c9_8cfb80a1?usp=em... : PS1, Line 222: mcupm MCUPM
https://review.coreboot.org/c/blobs/+/86095/comment/89410b0f_2561511d?usp=em... : PS1, Line 228: Use CBFS to load `pi_img.img`. ``` Load `pi_img.img` from CBFS. ```
https://review.coreboot.org/c/blobs/+/86095/comment/6681ed46_d30071fd?usp=em... : PS1, Line 229: No need to pass other parameters to pi_img Missing `.`
File soc/mediatek/mt8196/pi_img.img.md5:
https://review.coreboot.org/c/blobs/+/86095/comment/93a8f3dc_c7c31be4?usp=em... : PS1, Line 1: 357c892eea80a341201b9493de177362 Seems incorrect. My result starts with `d0f3`.