Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/29274 )
Change subject: soc/intel/cannonlake: Enable ISH from device ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29274/1/src/soc/intel/cannonlake/romstage/fs... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/#/c/29274/1/src/soc/intel/cannonlake/romstage/fs... PS1, Line 59: const struct device *dev = dev_find_slot(0, PCH_DEVFN_ISH); move this to the beginning of the function