Attention is currently required from: Arthur Heymans, Ashish Kumar Mishra, Paul Menzel, Saurabh Mishra, Subrata Banik.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82079?usp=email )
Change subject: block/fast_spi: Use read32p/write32p for spi rw
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/82079/comment/db7b4704_03eb0d52 :
PS2, Line 80: const uint8_t *byte_ptr = (const uint8_t *)data;
: size_t bytes_to_copy;
: union {
: uint32_t full;
: uint8_t bytes[4];
: } dword;
:
: for (size_t i = 0; i < len; i += 4) {
: dword.full = 0;
:
: bytes_to_copy = (len - i < 4) ? len - i : 4;
: for (size_t j = 0; j < bytes_to_copy; j++)
: dword.bytes[j] = byte_ptr[i + j];
:
: write32p(ctx->mmio_base + SPIBAR_FDATA(i >> 2), dword.full);
: }
A similar impl. […]
OK. Marking this as unresolved until the patch is actually updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82079?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I317c7160bf192dd2aeacebf6029a809bc97f3420
Gerrit-Change-Number: 82079
Gerrit-PatchSet: 2
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 24 Apr 2024 16:03:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment