Attention is currently required from: Shuo Liu.
Nicholas Chin has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/86639?usp=email )
Change subject: cbfstool: Fix the help text ......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86639/comment/f5f7ffd7_7c6eccb7?usp... : PS1, Line 10: updated Maybe "corrected"? The use of "updated" gave me the impression that the option was previously changed from mmio to mmap, but when looking for the commit where that happened it seems to have just been a mistake in commit c52ffcede366 ("cbfs: Remove remnants of ext-win-*") which was updating the help text to account for commit 34a7e66faa46 ("util/cbfstool: Add a new mechanism to provide a memory map").
It would also be good to reference 34a7e66faa46 where the mmap option was originally added.
-
Nicholas Chin (Code Review)