build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46441 )
Change subject: util/ifdtool: Enable CPU read of the ME region ......................................................................
Patch Set 8:
(15 comments)
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1271 PS8, Line 1271: int rd_shift; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1271 PS8, Line 1271: int rd_shift; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1272 PS8, Line 1272: fmba_t *fmba = find_fmba(image, size); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1272 PS8, Line 1272: fmba_t *fmba = find_fmba(image, size); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1275 PS8, Line 1275: exit(EXIT_FAILURE); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1275 PS8, Line 1275: exit(EXIT_FAILURE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1277 PS8, Line 1277: if (ifd_version >= IFD_VERSION_2) { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1277 PS8, Line 1277: if (ifd_version >= IFD_VERSION_2) { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1277 PS8, Line 1277: if (ifd_version >= IFD_VERSION_2) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1278 PS8, Line 1278: rd_shift = FLMSTR_RD_SHIFT_V2; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1278 PS8, Line 1278: rd_shift = FLMSTR_RD_SHIFT_V2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1279 PS8, Line 1279: } else { code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1279 PS8, Line 1279: } else { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1283 PS8, Line 1283: /* CPU/BIOS can read ME. */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46441/8/util/ifdtool/ifdtool.c@1674 PS8, Line 1674: int mode_em100 = 0, mode_locked = 0, mode_read = 0, mode_unlocked = 0, mode_validate = 0; line over 96 characters
-
build bot (Jenkins) (Code Review)