Attention is currently required from: Ethan Tsao, Paul Menzel, Tim Wawrzynczak, Subrata Banik, Raj Astekar, Patrick Rudolph, Felix Held.
Ethan Tsao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58317 )
Change subject: soc/intel/common/acpi: Correct IPC sub command for reading LPM requirement
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58317/comment/1340c51d_3ba2bddb
PS1, Line 9: Modify IPC sub command to 2 from 0 for reading LPM requirement from PMC.
Please add that URL.
Hi Paul,
Can you please clarify what URL you are looking for here?
Patchset:
PS1:
the indentation of the new code looks a bit off to me. […]
Thanks reminding. Tab size of 4 is accidently used. Has update patch.
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/58317/comment/2c404ff1_becb296f
PS1, Line 51:
line up with `PMC_IPC_CMD_RD_PMC_REG` above?
Thanks reminding. Has update patch.
File src/soc/intel/common/block/include/intelblocks/pmc_ipc.h:
https://review.coreboot.org/c/coreboot/+/58317/comment/9b2e8435_9955fd2c
PS1, Line 42:
remove the extra tab here
Thanks reminding. Has update patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58509f14f1e67472adda78e65c3a2e3ee9210765
Gerrit-Change-Number: 58317
Gerrit-PatchSet: 2
Gerrit-Owner: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Ethan Tsao
ethan.tsao@intel.corp-partner.google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Ethan Tsao
ethan.tsao@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 25 Oct 2021 17:01:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ethan Tsao
ethan.tsao@intel.corp-partner.google.com
Comment-In-Reply-To: Ethan Tsao
ethan.tsao@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment