Change in coreboot[master]: soc/intel/alderlake/hsphy: Add support for HSPHY firmware loading

[build bot (Jenkins) (Code Review)]

Attention is currently required from: Maulik V Vaghela, Jeremy Soller, Michał Kopeć, Tim Wawrzynczak, Paul Menzel, Ronak Kanabar.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64074 )

Change subject: soc/intel/alderlake/hsphy: Add support for HSPHY firmware loading
......................................................................

Patch Set 5:

(8 comments)

File src/soc/intel/alderlake/hsphy.c:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283):
https://review.coreboot.org/c/coreboot/+/64074/comment/d6b70ea9_d13eda29 
PS5, Line 28: #define HSPHY_PAYLOAD_SIZE		32*KiB
Macros with complex values should be enclosed in parentheses

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283):
https://review.coreboot.org/c/coreboot/+/64074/comment/d9a2b4c3_7d183426 
PS5, Line 40: #define   HSPHY_MEM_VERIFIER_ERROR_STATUS 		(HSPHY_VERIFIER_BASE + 0x30)
please, no space before tabs

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283):
https://review.coreboot.org/c/coreboot/+/64074/comment/def07b78_93b28944 
PS5, Line 67: }__packed;
space required after that close brace '}'

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283):
https://review.coreboot.org/c/coreboot/+/64074/comment/493fe786_dd1f3b48 
PS5, Line 159: 		printk (BIOS_ERR, "Hash alg %d not supported, try SHA384\n", hash_alg);
space prohibited between function name and open parenthesis '('

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283):
https://review.coreboot.org/c/coreboot/+/64074/comment/d9e3e603_59f2d5a3 
PS5, Line 187: 		i += sizeof (*push_model);
space prohibited between function name and open parenthesis '('

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283):
https://review.coreboot.org/c/coreboot/+/64074/comment/dbbb28aa_4f880ab6 
PS5, Line 195: 			i += sizeof (uint32_t);
space prohibited between function name and open parenthesis '('

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283):
https://review.coreboot.org/c/coreboot/+/64074/comment/7dae260f_9f5a0e41 
PS5, Line 312: 		hsphy_ver = REGBAR32(CPU_PID_PCIE_PHYx16_0, HSPHY_FW_VERSION);;
Statements terminations use 1 semicolon

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150283):
https://review.coreboot.org/c/coreboot/+/64074/comment/e8e91db3_5e7cbf8f 
PS5, Line 317: 		hsphy_ver = REGBAR32(CPU_PID_PCIE_PHYx16_1, HSPHY_FW_VERSION);;
Statements terminations use 1 semicolon