Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52732 )
Change subject: mb/intel/adlrvp: Align chromeos.fmd file with Brya
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52732/comment/f4d9df19_b176532e
PS2, Line 9: While moving to emerge build for coreboot
I think it would be better to say that when building adlrvp with chromeos.fmd layout and adding all Chrome OS related artifacts, adlrvp is running out of space in RO region.
https://review.coreboot.org/c/coreboot/+/52732/comment/8c5cb7a9_48ab3b5b
PS2, Line 10: align with Brya
Rather than aligning with brya, what is more important is creating space in RO. Yes, aligning with brya helps because it has the same requirements. But, The primary issue is that adlrvp runs out of space in RO when building for Chrome OS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52732
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I644e2e5ba06d2b816d413a7cc9f5f248d8a6fee8
Gerrit-Change-Number: 52732
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Spoorthi K
spoorthi.k@intel.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 28 Apr 2021 21:50:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment