Change in coreboot[master]: mb/google/poppy: Add retail names

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42143 )

Change subject: mb/google/poppy: Add retail names
......................................................................

mb/google/poppy: Add retail names

Taken from Chrome OS update information. Looks like nami encompasses
many different devices, which would not fit in one line, so skip it.

Change-Id: I53405cba269cbfc25bd4618777b946500f173e7e
Signed-off-by: Angel Pons 
---
M src/mainboard/google/poppy/Kconfig.name
1 file changed, 5 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/42143/1

diff --git a/src/mainboard/google/poppy/Kconfig.name b/src/mainboard/google/poppy/Kconfig.name
index c33d7fb..9ecdb44 100644
--- a/src/mainboard/google/poppy/Kconfig.name
+++ b/src/mainboard/google/poppy/Kconfig.name
@@ -1,7 +1,7 @@
 comment "Poppy"

config BOARD_GOOGLE_ATLAS
-	bool "->  Atlas"
+	bool "->  Atlas (Google Pixelbook Go)"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_ATLAS

@@ -16,21 +16,21 @@
    select VARIANT_SPECIFIC_OPTIONS_NAMI

config BOARD_GOOGLE_NAUTILUS
-	bool "->  Nautilus"
+	bool "->  Nautilus (Samsung Chromebook Plus (V2 / LTE))"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_NAUTILUS

config BOARD_GOOGLE_NOCTURNE
-	bool "->  Nocturne"
+	bool "->  Nocturne (Google Pixel Slate)"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_NOCTURNE

config BOARD_GOOGLE_RAMMUS
-	bool "->  Rammus"
+	bool "->  Rammus (Asus Chromebook C425, Flip C433, Flip C434)"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_RAMMUS

config BOARD_GOOGLE_SORAKA
-	bool "->  Soraka"
+	bool "->  Soraka (HP Chromebook x2)"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_SORAKA

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42143 )

Change subject: mb/google/poppy: Add retail names
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/42143/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42143/1//COMMIT_MSG@9 
PS1, Line 9:  Looks like nami encompasses
           : many different devices, which would not fit in one line, so skip it.
would it make sense to add a few new board aliases that just select BOARD_GOOGLE_NAMI so that all the retail devices have an entry?

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42143 )

Change subject: mb/google/poppy: Add retail names
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42143 )

Change subject: mb/google/poppy: Add retail names
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42143/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42143/1//COMMIT_MSG@9 
PS1, Line 9:  Looks like nami encompasses
           : many different devices, which would not fit in one line, so skip it.
> would it make sense to add a few new board aliases that just select BOARD_GOOGLE_NAMI so that all th […]

We can't really select BOARD_GOOGLE_NAMI because it's a symbol in a prompt. We'd need to have separate symbols that are then handled the same. Sure, we could simply have those select a BOARD_GOOGLE_NAMI symbol that is not inside Kconfig.name, but I'd prefer to do that kind of surgery in a separate change.

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42143 )

Change subject: mb/google/poppy: Add retail names
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/42143/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/42143/1//COMMIT_MSG@9 
PS1, Line 9:  Looks like nami encompasses
           : many different devices, which would not fit in one line, so skip it.
> We can't really select BOARD_GOOGLE_NAMI because it's a symbol in a prompt. […]

fair enough

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42143 )

Change subject: mb/google/poppy: Add retail names
......................................................................

mb/google/poppy: Add retail names

Taken from Chrome OS update information. Looks like nami encompasses
many different devices, which would not fit in one line, so skip it.

Change-Id: I53405cba269cbfc25bd4618777b946500f173e7e
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42143
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Matt DeVillier 
---
M src/mainboard/google/poppy/Kconfig.name
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Matt DeVillier: Looks good to me, approved

diff --git a/src/mainboard/google/poppy/Kconfig.name b/src/mainboard/google/poppy/Kconfig.name
index c33d7fb..9ecdb44 100644
--- a/src/mainboard/google/poppy/Kconfig.name
+++ b/src/mainboard/google/poppy/Kconfig.name
@@ -1,7 +1,7 @@
 comment "Poppy"

config BOARD_GOOGLE_ATLAS
-	bool "->  Atlas"
+	bool "->  Atlas (Google Pixelbook Go)"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_ATLAS

@@ -16,21 +16,21 @@
    select VARIANT_SPECIFIC_OPTIONS_NAMI

config BOARD_GOOGLE_NAUTILUS
-	bool "->  Nautilus"
+	bool "->  Nautilus (Samsung Chromebook Plus (V2 / LTE))"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_NAUTILUS

config BOARD_GOOGLE_NOCTURNE
-	bool "->  Nocturne"
+	bool "->  Nocturne (Google Pixel Slate)"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_NOCTURNE

config BOARD_GOOGLE_RAMMUS
-	bool "->  Rammus"
+	bool "->  Rammus (Asus Chromebook C425, Flip C433, Flip C434)"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_RAMMUS

config BOARD_GOOGLE_SORAKA
-	bool "->  Soraka"
+	bool "->  Soraka (HP Chromebook x2)"
    select BOARD_GOOGLE_BASEBOARD_POPPY
    select VARIANT_SPECIFIC_OPTIONS_SORAKA